Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): correct error handling for envConfig #165

Merged
merged 2 commits into from
Aug 3, 2023
Merged

fix(config): correct error handling for envConfig #165

merged 2 commits into from
Aug 3, 2023

Conversation

shini4i
Copy link
Owner

@shini4i shini4i commented Aug 3, 2023

Fix for cases when envConfig.Process returns an error. Now we are printing the correct error.

@shini4i shini4i requested a review from tomsozolins August 3, 2023 14:52
tomsozolins
tomsozolins previously approved these changes Aug 3, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@shini4i shini4i merged commit b4238ff into main Aug 3, 2023
@shini4i shini4i deleted the fix/correct-envconfig-error-handling branch August 3, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsozolins tomsozolins tomsozolins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shini4i @tomsozolins